StarlingTextureLoader memory leak?

matulk

Hello,

I want to use StarlingTextureLoader class to load multiple Atlases for a single skeleton. Looking in the source code, it seems to me that this class is instantiating Textures from bitmapDatas, but never disposes them.

Shouldn't they be disposed in the unload() function?

Cheers

Nate

Hmm, probably, Starling docs don't say a Texture needs to be disposed explicitly.
http://doc.starling-framework.org/core/ ... xture.html
I guess we should dispose both the BitmapData and the Texture in unload? This is annoying since it seems the BitmapData cannot be gotten from the Texture.

matulk

I am a bit new to Starling as well, but I am 99% sure Textures have to be disposed so they get removed from gpu memory. I do not have Adobe Scout installed at the moment so I can not confirm yet.

Anyways, I just realized that page.rendererObject in that case actually is a Texture, not a BitmapData. So you are actually disposing the Texture. So there is a bug in the unload() Function:

public function unloadPage (page:AtlasPage) : void {
	BitmapData(page.rendererObject).dispose();
}

Obviously it crashes. Instead it should be:

public function unloadPage (page:AtlasPage) : void {
        var texture: Texture = page.rendererObject as Texture;
        texture.dispose();
}

This works. The BitmapData will not be disposed here at all. Which is fine, because it is also not instantiated here.

Nate

Committed, thanks! Hopefully we don't need to dispose the BitmapData.

matulk

I guess the same class which instantiated the bitmapData should also be responsible for disposing it. So it should be fine anyways.

Thanks for the commit.